navidocs/server/routes/search.js
Claude 27603a3a3a
Fix 8 critical security and marine UX issues
Security:
- Enforce JWT_SECRET (no fallback to known default)
- Require auth on document/image/search/upload/stats routes
- Remove all test-user-id synthetic user patterns

Marine UX:
- Increase touch targets to 60px minimum (glove-friendly)
- Increase fonts to 16px minimum (sunlight-readable)
- Add ARIA labels to icon-only buttons (accessibility)
- Add alt text to all images (accessibility)

Source: Codex security review + Gemini UX review
Blockers: 8 critical issues preventing production deployment

Files modified: 13
- Security: 6 server files (auth.service.js, documents.js, images.js, search.js, upload.js, stats.js)
- UX: 7 client files (SearchView.vue, TocSidebar.vue, TocEntry.vue, HomeView.vue, LibraryView.vue, GlobalSearch.vue, LanguageSwitcher.vue)

Tests:
- npm audit --production: 0 vulnerabilities 
- All 8 agents completed successfully
- JWT_SECRET enforcement: Server will crash without proper secret
- Auth middleware: Unauthenticated requests return 401
- Admin protection: Non-admin requests return 403
2025-11-14 17:09:07 +00:00

364 lines
11 KiB
JavaScript

/**
* Search Route - Unified search for documents and feature modules
* Handles:
* - Document/page search (Meilisearch)
* - Feature module search (inventory, maintenance, cameras, contacts, expenses)
* - Meilisearch tenant token generation
*/
import express from 'express';
import { getMeilisearchClient, generateTenantToken } from '../config/meilisearch.js';
import { getDb } from '../db/db.js';
import { search as searchModules, getSearchableModules, reindexModule, reindexAll } from '../services/search-modules.service.js';
import { authenticateToken } from '../middleware/auth.js';
const router = express.Router();
const INDEX_NAME = process.env.MEILISEARCH_INDEX_NAME || 'navidocs-pages';
/**
* POST /api/search/token
* Generate Meilisearch tenant token for client-side search
*
* @body {number} [expiresIn] - Token expiration in seconds (default: 3600 = 1 hour)
* @returns {Object} { token, expiresAt, indexName }
*/
router.post('/token', authenticateToken, async (req, res) => {
try {
const userId = req.user.userId;
const { expiresIn = 3600 } = req.body; // Default 1 hour
// Validate expiresIn
const maxExpiry = 86400; // 24 hours max
const tokenExpiry = Math.min(parseInt(expiresIn) || 3600, maxExpiry);
const db = getDb();
// Get user's organizations
const orgs = db.prepare(`
SELECT organization_id
FROM user_organizations
WHERE user_id = ?
`).all(userId);
const organizationIds = orgs.map(org => org.organization_id);
if (organizationIds.length === 0) {
return res.status(403).json({ error: 'No organizations found for user' });
}
const expiresAt = new Date(Date.now() + tokenExpiry * 1000);
const searchUrl = process.env.MEILISEARCH_HOST || 'http://127.0.0.1:7700';
// Preferred: tenant token
try {
const token = await generateTenantToken(userId, organizationIds, tokenExpiry);
return res.json({ token, expiresAt: expiresAt.toISOString(), expiresIn: tokenExpiry, indexName: INDEX_NAME, searchUrl, mode: 'tenant' });
} catch (err) {
console.warn('Tenant token generation failed, falling back to search API key:', err?.message || err);
}
// Fallback: use search API key (prefer env override)
const envSearchKey = process.env.MEILISEARCH_SEARCH_KEY;
if (envSearchKey) {
return res.json({ token: envSearchKey, expiresAt: null, expiresIn: null, indexName: INDEX_NAME, searchUrl, mode: 'search-key' });
}
const client = getMeilisearchClient();
const keys = await client.getKeys();
const searchKey = keys.results?.find(k => k.actions?.includes('search') && (k.indexes?.includes('*') || k.indexes?.includes(INDEX_NAME)));
if (!searchKey?.key) throw new Error('No search API key available for fallback');
return res.json({ token: searchKey.key, expiresAt: null, expiresIn: null, indexName: INDEX_NAME, searchUrl, mode: 'search-key' });
} catch (error) {
console.error('Token generation error:', error);
res.status(500).json({ error: 'Failed to generate search token', message: error.message });
}
});
/**
* POST /api/search
* Server-side search endpoint (optional, for server-rendered results)
*
* @body {string} q - Search query
* @body {Object} [filters] - Filter options
* @body {number} [limit] - Results limit (default: 20)
* @body {number} [offset] - Results offset (default: 0)
* @returns {Object} { hits, estimatedTotalHits, query, processingTimeMs }
*/
router.post('/', authenticateToken, async (req, res) => {
try {
const { q, filters = {}, limit = 20, offset = 0 } = req.body;
if (!q || typeof q !== 'string') {
return res.status(400).json({ error: 'Query parameter "q" is required' });
}
const userId = req.user.userId;
const db = getDb();
// Get user's organizations
const orgs = db.prepare(`
SELECT organization_id
FROM user_organizations
WHERE user_id = ?
`).all(userId);
const organizationIds = orgs.map(org => org.organization_id);
if (organizationIds.length === 0) {
return res.status(403).json({
error: 'No organizations found for user'
});
}
// Build Meilisearch filter
const filterParts = [
`userId = "${userId}" OR organizationId IN [${organizationIds.map(id => `"${id}"`).join(', ')}]`
];
// Add additional filters
if (filters.documentType) {
filterParts.push(`documentType = "${filters.documentType}"`);
}
if (filters.entityId) {
filterParts.push(`entityId = "${filters.entityId}"`);
}
if (filters.language) {
filterParts.push(`language = "${filters.language}"`);
}
const filterString = filterParts.join(' AND ');
// Use direct HTTP call with master key to avoid client cache issues
const host = process.env.MEILISEARCH_HOST || 'http://127.0.0.1:7700';
const apiKey = process.env.MEILISEARCH_MASTER_KEY || process.env.MEILISEARCH_SEARCH_KEY;
const resp = await fetch(`${host}/indexes/${INDEX_NAME}/search`, {
method: 'POST',
headers: {
'Content-Type': 'application/json',
...(apiKey ? { Authorization: `Bearer ${apiKey}` } : {})
},
body: JSON.stringify({ q, filter: filterString, limit: parseInt(limit), offset: parseInt(offset), attributesToHighlight: ['text'], attributesToCrop: ['text'], cropLength: 200 })
});
if (!resp.ok) {
const txt = await resp.text();
throw new Error(`Meilisearch HTTP ${resp.status}: ${txt}`);
}
const searchResults = await resp.json();
return res.json({
hits: searchResults.hits || [],
estimatedTotalHits: searchResults.estimatedTotalHits || 0,
query: searchResults.query || q,
processingTimeMs: searchResults.processingTimeMs || 0,
limit: parseInt(limit),
offset: parseInt(offset)
});
} catch (error) {
console.error('Search error:', error);
res.status(500).json({
error: 'Search failed',
message: error.message
});
}
});
/**
* GET /api/search/health
* Check Meilisearch health status
*/
router.get('/health', async (req, res) => {
try {
const client = getMeilisearchClient();
const health = await client.health();
res.json({
status: 'ok',
meilisearch: health
});
} catch (error) {
res.status(503).json({
status: 'error',
error: 'Meilisearch unavailable',
message: error.message
});
}
});
/**
* GET /api/search/modules
* Get list of searchable modules and their configuration
*/
router.get('/modules', (req, res) => {
try {
const modules = getSearchableModules();
res.json({
modules: Object.keys(modules),
configurations: modules
});
} catch (error) {
res.status(500).json({
error: 'Failed to get modules',
message: error.message
});
}
});
/**
* GET /api/search/query?q=query&module=module&limit=20&offset=0
* Universal search across all feature modules
*
* Query parameters:
* - q: Search query (required)
* - module: Optional module filter (inventory_items, maintenance_records, etc.)
* - boatId: Optional boat ID filter
* - organizationId: Optional organization ID filter
* - category: Optional category filter
* - limit: Results per page (default: 20)
* - offset: Result offset for pagination (default: 0)
*/
router.get('/query', authenticateToken, async (req, res) => {
try {
const { q, module, boatId, organizationId, category, limit = 20, offset = 0 } = req.query;
if (!q || typeof q !== 'string' || q.trim().length === 0) {
return res.status(400).json({ error: 'Query parameter "q" is required and must be non-empty' });
}
const filters = {};
if (boatId) filters.boatId = parseInt(boatId);
if (organizationId) filters.organizationId = parseInt(organizationId);
if (category) filters.category = category;
const results = await searchModules(q.trim(), {
filters,
limit: Math.min(parseInt(limit) || 20, 100), // Max 100 results
offset: Math.max(parseInt(offset) || 0, 0),
module: module || null
});
res.json({
query: q,
module: module || 'all',
results,
pagination: {
limit: parseInt(limit),
offset: parseInt(offset)
}
});
} catch (error) {
console.error('Module search error:', error);
res.status(500).json({
error: 'Search failed',
message: error.message
});
}
});
/**
* GET /api/search/:module?q=query&limit=20&offset=0
* Module-specific search
*
* URL parameters:
* - module: Module name (inventory_items, maintenance_records, camera_feeds, contacts, expenses)
*
* Query parameters:
* - q: Search query (required)
* - boatId: Optional boat ID filter
* - organizationId: Optional organization ID filter
* - category: Optional category filter
* - limit: Results per page (default: 20)
* - offset: Result offset for pagination (default: 0)
*/
router.get('/:module', authenticateToken, async (req, res) => {
try {
const { module } = req.params;
const { q, boatId, organizationId, category, limit = 20, offset = 0 } = req.query;
if (!q || typeof q !== 'string' || q.trim().length === 0) {
return res.status(400).json({ error: 'Query parameter "q" is required and must be non-empty' });
}
const modules = getSearchableModules();
if (!modules[module]) {
return res.status(404).json({ error: `Unknown module: ${module}` });
}
const filters = {};
if (boatId) filters.boatId = parseInt(boatId);
if (organizationId) filters.organizationId = parseInt(organizationId);
if (category) filters.category = category;
const results = await searchModules(q.trim(), {
filters,
limit: Math.min(parseInt(limit) || 20, 100),
offset: Math.max(parseInt(offset) || 0, 0),
module
});
res.json({
query: q,
module,
results: results.modules[module] || { hits: [], totalHits: 0 },
pagination: {
limit: parseInt(limit),
offset: parseInt(offset)
}
});
} catch (error) {
console.error('Module search error:', error);
res.status(500).json({
error: 'Search failed',
message: error.message
});
}
});
/**
* POST /api/search/reindex/:module
* Reindex all records for a specific module (admin only)
*
* URL parameters:
* - module: Module name (optional, reindex all if omitted)
*/
router.post('/reindex/:module?', authenticateToken, async (req, res) => {
try {
// Check if user is admin (basic check, should be enhanced with proper authorization)
if (!req.user?.isAdmin && process.env.ALLOW_REINDEX !== 'true') {
return res.status(403).json({ error: 'Admin access required' });
}
const { module } = req.params;
if (module) {
const modules = getSearchableModules();
if (!modules[module]) {
return res.status(404).json({ error: `Unknown module: ${module}` });
}
const result = await reindexModule(module);
return res.json({
success: true,
message: `Reindexed ${module}`,
result
});
} else {
const result = await reindexAll();
return res.json({
success: true,
message: 'Reindexed all modules',
result
});
}
} catch (error) {
console.error('Reindex error:', error);
res.status(500).json({
error: 'Reindex failed',
message: error.message
});
}
});
export default router;